Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.nims search path in docs #9388

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

kaushalmodi
Copy link
Contributor

Related: #8682

/cc @timotheecour @Araq

Related: nim-lang#8682

Also mention the "nim help" command to list all available tasks.
@kaushalmodi kaushalmodi force-pushed the config-nims-search-path-docs branch from dab7566 to f91090e Compare October 16, 2018 14:05
@kaushalmodi
Copy link
Contributor Author

@Araq Looks like the failure is only due to tfragment_gc on OSX: https://travis-ci.org/nim-lang/Nim/jobs/442193457#L3201

The PR touches only the nims.rst file.

``~/.config/nim/config.nims`` (POSIX) or
``%APPDATA%/nim/config.nims`` (Windows). This file can be skipped
with the ``--skipUserCfg`` command line option.
2) ``$parentDir/config.nims`` where ``$parentDir`` stands for any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been implemented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean that the --skip* switches don't apply to .nims files? I then misunderstood the above referenced applied PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true then?

1) If environment variable ``XDG_CONFIG_HOME`` is defined,
   ``$XDG_CONFIG_HOME/nim/config.nims`` or
   ``~/.config/nim/config.nims`` (POSIX) or
   ``%APPDATA%/nim/config.nims`` (Windows) will be used.
2) Next, if ``config.nims`` is placed inside a directory, that will
   apply to all Nim projects inside that directory.
3) Next, if a project has ``<project>.nims`` that resides in the same
   directory as the ``<project>.nim``, that will apply finally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Araq I believe I did implement it, see https://github.com/nim-lang/Nim/pull/8682/files#diff-5fdd8f1b1ac3aa10d48e0af960fb8c17R52
when I pass --skipUserCfg, /Users/timothee/.config/nim/config.nims is skipped

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I misremembered then.

@Araq
Copy link
Member

Araq commented Oct 16, 2018

Unrelated test failure, merging.

@Araq Araq merged commit 3e9f506 into nim-lang:devel Oct 16, 2018
narimiran pushed a commit to narimiran/Nim that referenced this pull request Oct 31, 2018
Related: nim-lang#8682

Also mention the "nim help" command to list all available tasks.
narimiran pushed a commit to narimiran/Nim that referenced this pull request Nov 1, 2018
Related: nim-lang#8682

Also mention the "nim help" command to list all available tasks.
narimiran pushed a commit that referenced this pull request Nov 1, 2018
Related: #8682

Also mention the "nim help" command to list all available tasks.
narimiran pushed a commit that referenced this pull request Nov 1, 2018
Related: #8682

Also mention the "nim help" command to list all available tasks.

(cherry picked from commit 3e9f506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants